Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PhpunitBridge] Restore memoization #31955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Jun 8, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

I must have inadvertently dropped it in 1c73f9c

@greg0ire greg0ire changed the title Restore memoization [PhpunitBridge] Restore memoization Jun 8, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 8, 2019
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php Outdated Show resolved Hide resolved
@greg0ire greg0ire force-pushed the restore-memoization branch from 23e13eb to 8ff10a4 Compare June 8, 2019 14:24
@greg0ire
Copy link
Contributor Author

greg0ire commented Jun 8, 2019

Looks like I broke something 😕

EDIT: should be fine now.

I should have removed it in 1c73f9c
@greg0ire greg0ire force-pushed the restore-memoization branch from 8ff10a4 to 3b0e9df Compare June 8, 2019 14:35
@@ -215,9 +214,7 @@ private function getConfiguration()
if (null !== $this->configuration) {
return $this->configuration;
}
if (false === $mode = $this->mode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is legit: the property is used L88.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, good catch! Closing then.

@greg0ire greg0ire closed this Jun 9, 2019
@greg0ire greg0ire deleted the restore-memoization branch June 9, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.