[Translation] Fixed case sensitivity of lint:xliff command #31786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Jun 1, 2019
chalasr
approved these changes
Jun 1, 2019
fabpot
requested changes
Jun 2, 2019
nicolas-grekas
approved these changes
Jun 3, 2019
0452b68 to
ec690b2
Compare
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 3, 2019
… (javiereguiluz) This PR was squashed before being merged into the 4.2 branch (closes #31786). Discussion ---------- [Translation] Fixed case sensitivity of lint:xliff command | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | (not needed) I was checking some errors of `lint:xliff` (https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/540053551#L657) and saw this: ``` ERROR in src/Resources/translations/EasyAdminBundle.sr_RS.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.sr_RS.xlf") and the "sr-rs" value used in the "target-language" attribute of the file. ERROR in src/Resources/translations/EasyAdminBundle.zh_CN.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.zh_CN.xlf") and the "zh-cn" value used in the "target-language" attribute of the file. ``` This was suspicious, so I checked the XLIFF standard and it says (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#target-language): ``` target-language: Unlike the other XLIFF attributes, the values are not case-sensitive. ``` So, it's valid that `zh-cn` is the target language and `zh-CN` is the file extension. This PR fixes that. Commits ------- ec690b2 [Translation] Fixed case sensitivity of lint:xliff command
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking some errors of
lint:xliff(https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/540053551#L657) and saw this:This was suspicious, so I checked the XLIFF standard and it says (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#target-language):
So, it's valid that
zh-cnis the target language andzh-CNis the file extension. This PR fixes that.