[Messenger] Fix redis Connection::get() should be non blocking by default #31545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
commented
May 19, 2019
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
a64ef8e to
454a738
Compare
|
ping @alexander-schranz also :) |
705b6f8 to
81136e7
Compare
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
Outdated
Show resolved
Hide resolved
alexander-schranz
suggested changes
May 20, 2019
There was a problem hiding this comment.
xReadGroup should be non blocking aslong as we don't give a block time. Did I implement there something false?
And as written the xlen I think is the false way to get the correct count value as this does also include pending and received messages.
81136e7 to
f478351
Compare
alexander-schranz
approved these changes
May 20, 2019
There was a problem hiding this comment.
As discussed on slack this seems currently the only way to avoid a blocking request to omit the blocking parameter of xreadgroup function.
@chalasr thank you for fixing this 👍
f478351 to
229502a
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 21, 2019
…king by default (chalasr) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix redis Connection::get() should be non blocking by default | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | todo The `\Redis::xreadgroup()` method waits until a message arrives or the specified timeout is reached before returning, which means that `RedisExt\Connection::get()` is blocking. That's inconsistent with other transports which all returns immediately in case there is no message, for instance the AMQP transport uses `\Amqp::get()` instead of `\Amqp::consume()` for this reason. It also short-circuits the worker's stop logic: both the `--time-limit` option of the `messenger:consume` command and the `messenger:stop-workers` don't work with the redis transport. This returns early in case the message count is 0 and no blocking timeout has been configured. Commits ------- 229502a [Messenger] Make redis Connection::get() non blocking by default
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\Redis::xreadgroup()method waits until a message arrives or the specified timeout is reached before returning, which means thatRedisExt\Connection::get()is blocking.That's inconsistent with other transports which all returns immediately in case there is no message, for instance the AMQP transport uses
\Amqp::get()instead of\Amqp::consume()for this reason.It also short-circuits the worker's stop logic: both the
--time-limitoption of themessenger:consumecommand and themessenger:stop-workersdon't work with the redis transport.This returns early in case the message count is 0 and no blocking timeout has been configured.