[Workflow] use method marking store #31537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you look at the CI? |
|
@lyrixx PR desc update accordingly |
lyrixx
approved these changes
May 20, 2019
|
Thank you @noniagriconomie. |
nicolas-grekas
added a commit
that referenced
this pull request
May 20, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] use method marking store | Q | A | ------------- | --- | Branch? | 4.3 (related to deprecation of single/multiple marking store) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | . | License | MIT | Doc PR | already documented I think the deprecation of old marking store, the single one in the statemachine, was not patched here Or did i miss something? Thank you Cc @lyrixx Commits ------- a219167 [Workflow] use method marking store
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the deprecation of old marking store, the single one in the statemachine, was not patched here
Or did i miss something?
Thank you
Cc @lyrixx