[WebProfilerBundle][Form] The form data collector return serialized data #31502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about fixing the constraints between the Form component and WebProfileBundle instead? |
|
@fabpot What will happen on the existing application requiring already theses versions (so with the bug) ? |
|
The bug will still be there I suppose... but that's the same with your fix... you need to update to get it. I prefer to avoid having too many specific code to support different versions, bumping min versions is usually what we do. |
|
What is the version we would have to require to not have to use this code? |
|
That's what I'm looking into, need to search @xabbuh |
04c86fa to
f04f415
Compare
|
@fabpot I've added a conflict in the WebProfilerBundle to avoid using the Form component below 4.3 since there are no real dependencies between the two, WDYT ? |
…bject when profiler bundle attends object
f04f415 to
70fdafd
Compare
fabpot
approved these changes
May 18, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
May 18, 2019
…erialized data (Simperfit) This PR was merged into the 4.3 branch. Discussion ---------- [WebProfilerBundle][Form] The form data collector return serialized data | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31476 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | not needed <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle. This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data. Commits ------- 70fdafd [WebProfilerBundle][Form] The form data collector return serialized object when profiler bundle attends object
Merged
|
Thanks for the fix @Simperfit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.
This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.