[FrameworkBundle]: use __invoke function if no method is defined in r… #31367
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,24 @@ | |
|
|
||
| class ControllerResolverTest extends ContainerControllerResolverTest | ||
| { | ||
| public function testGetControllerWithServiceWithoutMethod() | ||
| { | ||
| class_exists(AbstractControllerTest::class); | ||
|
There was a problem hiding this comment. What is the reason for the There was a problem hiding this comment. No specific reason. Think it's better to remove it but since I have to start from master branch, I should rework the entire new code |
||
|
|
||
| $dummyController = new DummyController(); | ||
| $container = new Container(); | ||
| $container->set('app.index_controller', $dummyController); | ||
|
|
||
| $resolver = $this->createControllerResolver(null, $container); | ||
| $request = Request::create('/'); | ||
| $request->attributes->set('_controller', 'app.index_controller'); | ||
|
|
||
| $controller = $resolver->getController($request); | ||
|
|
||
| $this->assertSame($container, $controller[0]->getContainer()); | ||
| $this->assertSame('__invoke', $controller[1]); | ||
|
There was a problem hiding this comment. @rjwebdev I would follow the same logic as in $this->assertInstanceOf('Symfony\Bundle\FrameworkBundle\Tests\Controller\DummyController', $controller);
$this->assertInstanceOf('Symfony\Component\DependencyInjection\ContainerInterface', $controller->getContainer()); |
||
| } | ||
|
|
||
| public function testGetControllerOnContainerAware() | ||
| { | ||
| $resolver = $this->createControllerResolver(); | ||
|
|
@@ -230,6 +248,10 @@ public function getContainer() | |
| return $this->container; | ||
| } | ||
|
|
||
| public function __invoke() | ||
| { | ||
| } | ||
|
|
||
| public function fooAction() | ||
| { | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.