Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[TwigBridge] fix cross-version form theme tests #31327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2019
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 30, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh
Copy link
Member Author

xabbuh commented Apr 30, 2019

Status: Needs Review

@chalasr
Copy link
Member

chalasr commented Apr 30, 2019

The base branch and the milestone are not in sync though

@xabbuh xabbuh modified the milestones: 4.3, 3.4 Apr 30, 2019
@xabbuh xabbuh merged commit 730df08 into symfony:3.4 May 1, 2019
xabbuh added a commit that referenced this pull request May 1, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] fix cross-version form theme tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

730df08 relax assertions in tests
@xabbuh xabbuh deleted the pr-31293 branch May 1, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.