Optimize SVGs #31067
Merged
Optimize SVGs #31067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Apr 11, 2019
|
Anyone who can help me with the tests? Not sure what's causing these fails. |
|
Thank you @MartijnCuppens. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 11, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Optimize SVGs | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | / <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | / <!-- required for new features --> Used [svgo](https://github.com/svg/svgo) to optimize the svgs. I kept the `viewBox` attribute to keep the aspects when SVGs are rescaled. I also added `insert_final_newline = false` to the `.editorconfig` file because the newlines are removed from the SVGs and there's only one line left. Commits ------- 4614cea Optimize SVGs
|
there might be more in 4.2 if you want to have a look btw |
|
I just optimized them on 4.2 and master, because tests were failing otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used svgo to optimize the svgs. I kept the
viewBoxattribute to keep the aspects when SVGs are rescaled.I also added
insert_final_newline = falseto the.editorconfigfile because the newlines are removed from the SVGs and there's only one line left.