[TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory #30952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3be323a to
0edfaca
Compare
|
Updating tests |
e6db350 to
5cf238f
Compare
xabbuh
reviewed
Apr 7, 2019
src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
Outdated
Show resolved
Hide resolved
5cf238f to
89a00b3
Compare
|
Comments addressed, thank you @xabbuh |
fabpot
approved these changes
Apr 7, 2019
xabbuh
approved these changes
Apr 7, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2019
…f the legacy Twig template directory (yceruto) This PR was merged into the 4.2 branch. Discussion ---------- [TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #30088 | License | MIT #eu-fossa Commits ------- 89a00b3 Improving deprecation message of the Twig templates directory src/Resources/views
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#eu-fossa