Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Messenger] fixing unused variable names #30864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

weaverryan
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://github.com/symfony/symfony/pull/30757/files#r272061245
License MIT
Doc PR n/a

Typo on the variable name - variables aren't needed anyways.

Cheers!

Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👼

@fabpot
Copy link
Member

fabpot commented Apr 4, 2019

Thank you @weaverryan.

@fabpot fabpot merged commit f7ec2d3 into symfony:master Apr 4, 2019
fabpot added a commit that referenced this pull request Apr 4, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] fixing unused variable names

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/30757/files#r272061245
| License       | MIT
| Doc PR        | n/a

Typo on the variable name - variables aren't needed anyways.

Cheers!

Commits
-------

f7ec2d3 fixing unused variable names
@weaverryan weaverryan deleted the fix-minor-test-typo branch April 4, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.