-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] test DoctrineTransport on travis and appveyor #30857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25c3cbc
to
df21cf4
Compare
3c62139
to
3a41769
Compare
Thx for the help @nicolas-grekas . Nervermind juste run EDIT: Well ... this install |
666b212
to
00ceb4a
Compare
e6043de
to
488a8d8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I pushed the remaining fixes to make tests pass)
src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineIntegrationTest.php
Outdated
Show resolved
Hide resolved
488a8d8
to
8f81f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date changes do not cause any functionality loss as doctrine/dbal already didn’t support ms in DateTime (so delays already we’re in second precision, not ms, before this PR)
Thank you @vincenttouzet. |
…r (vincenttouzet) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] test DoctrineTransport on travis and appveyor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes ? WIP | Fixed tickets | | License | MIT | Doc PR | Currently tests on the `Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest` are skipped because there is no `MESSENGER_DOCTRINE_DSN` environment variable is not defined. This PR update the travis and AppVeyor configuration to run these tests. This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work Commits ------- 8f81f55 [Messenger] test DoctrineTransport on travis and appveyor
Currently tests on the
Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest
are skipped because there is noMESSENGER_DOCTRINE_DSN
environment variable is not defined.This PR update the travis and AppVeyor configuration to run these tests.
This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work