Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Messenger] test DoctrineTransport on travis and appveyor #30857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

vincenttouzet
Copy link
Contributor

@vincenttouzet vincenttouzet commented Apr 3, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes ? WIP
Fixed tickets
License MIT
Doc PR

Currently tests on the Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest are skipped because there is no MESSENGER_DOCTRINE_DSN environment variable is not defined.

This PR update the travis and AppVeyor configuration to run these tests.

This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work

@vincenttouzet vincenttouzet force-pushed the travis-messenger-doctrine branch 2 times, most recently from 25c3cbc to df21cf4 Compare April 3, 2019 20:17
.travis.yml Outdated Show resolved Hide resolved
.appveyor.yml Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 4, 2019
@vincenttouzet vincenttouzet force-pushed the travis-messenger-doctrine branch 3 times, most recently from 3c62139 to 3a41769 Compare April 4, 2019 18:04
@vincenttouzet
Copy link
Contributor Author

vincenttouzet commented Apr 4, 2019

Thx for the help @nicolas-grekas . Do you know how can I run test with deps=low locally ? I tried composer update --prefer-lowest --prefer-stable but I got errors and no tests are runned :(

Nervermind juste run composer up --prefer-lowest --prefer-stable then SYMFONY_PHPUNIT_VERSION=6.5.13 php phpunit src/Symfony/Component/Messenger/ and its fine :)

EDIT: Well ... this install doctrine/dbal v2.6.0 locally but it fails on travis with v2.4.0

@nicolas-grekas nicolas-grekas force-pushed the travis-messenger-doctrine branch from 666b212 to 00ceb4a Compare April 5, 2019 13:03
@nicolas-grekas nicolas-grekas changed the title RFC [Messenger] Add MESSENGER_DOCTRINE_DSN for travis and appveyor [Messenger] test DoctrineTransport on travis and appveyor Apr 5, 2019
@nicolas-grekas nicolas-grekas force-pushed the travis-messenger-doctrine branch 2 times, most recently from e6043de to 488a8d8 Compare April 5, 2019 13:19
@vincenttouzet vincenttouzet requested a review from sroze as a code owner April 5, 2019 13:19
@nicolas-grekas
Copy link
Member

cd src/Symfony/Component/Messenger/
composer up --prefer-lowest --prefer-stable
../../../../phpunit

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I pushed the remaining fixes to make tests pass)

@nicolas-grekas nicolas-grekas force-pushed the travis-messenger-doctrine branch from 488a8d8 to 8f81f55 Compare April 5, 2019 14:21
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date changes do not cause any functionality loss as doctrine/dbal already didn’t support ms in DateTime (so delays already we’re in second precision, not ms, before this PR)

@sroze
Copy link
Contributor

sroze commented Apr 6, 2019

Thank you @vincenttouzet.

@sroze sroze merged commit 8f81f55 into symfony:master Apr 6, 2019
sroze added a commit that referenced this pull request Apr 6, 2019
…r (vincenttouzet)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] test DoctrineTransport on travis and appveyor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes ? WIP
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently tests on the `Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest` are skipped because there is no `MESSENGER_DOCTRINE_DSN` environment variable is not defined.

This PR update the travis and AppVeyor configuration to run these tests.

This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work

Commits
-------

8f81f55 [Messenger] test DoctrineTransport on travis and appveyor
@vincenttouzet vincenttouzet deleted the travis-messenger-doctrine branch April 7, 2019 07:43
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.