[FrameworkBundle] Use only _route_params to generate redirect routes #3074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks... and no, this is not a bot ;) |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2012
Commits ------- af32590 [FrameworkBundle] Use only _route_params to generate redirect routes Discussion ---------- [FrameworkBundle] Use only _route_params to generate redirect routes Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Routes in RedirectController are generated using all request attributes, which is inconvenient since I abuse request attributes to store other things (device types and such) relevant to the app. It renders the RedirectController useless since it adds unrelated query parameters to URLs it creates.
| 'permanent' => $permanent, | ||
| ), | ||
| ); | ||
| $attributes['_route_params'] = $attributes['_route_params'] + $params; |
There was a problem hiding this comment.
Just a side note: $attributes['_route_params'] += $params; is equal to that ;-)
There was a problem hiding this comment.
True, feel free to send a PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Routes in RedirectController are generated using all request attributes, which is inconvenient since I abuse request attributes to store other things (device types and such) relevant to the app. It renders the RedirectController useless since it adds unrelated query parameters to URLs it creates.