[Form] IntegerType: reject submitted non-integer numbers #30329
Conversation
xabbuh
commented
Feb 21, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10240 |
| License | MIT |
| Doc PR |
|
Status: Needs work |
...ymfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
| @@ -40,6 +42,12 @@ public function __construct($scale = 0, $grouping = false, $roundingMode = self: | ||
| */ | ||
| public function reverseTransform($value) | ||
| { | ||
| $decimalSeparator = $this->getNumberFormatter()->getSymbol(\NumberFormatter::DECIMAL_SEPARATOR_SYMBOL); | ||
|
|
||
| if (\is_string($value) && false !== strpos($value, $decimalSeparator)) { |
There was a problem hiding this comment.
The transformation is invoked in reverse order in DateIntervalType when widget = integer, also in the model layer, so it could receive a real floating value here, isn't it?
There was a problem hiding this comment.
Can you give an example? I am not sure that I understand what you mean.
There was a problem hiding this comment.
symfony/src/Symfony/Component/Form/Extension/Core/Type/DateIntervalType.php
Lines 116 to 122 in 5a3e894
There was a problem hiding this comment.
Unlike IntegerType this transformation is invoked for model layer in reversed order, so I guess we should deal with real float values here.
There was a problem hiding this comment.
Basically, this is what I suggest:
if (false !== strpos((string) $value, $decimalSeparator)) {There was a problem hiding this comment.
Although, technically that should never happen because DateIntervalToArrayTransformer, so ignore my suggestion.
|
Thank you @xabbuh. |
…xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Form] IntegerType: reject submitted non-integer numbers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10240 | License | MIT | Doc PR | Commits ------- 6a43e74 IntegerType: reject submitted non-integer numbers