fix(component): Console -> argument consumption

A new argument has been added in order to consume or not the argument.
symfony · Guikingone · Jan 29, 2018 · Feb 10, 2018 · May 18, 2018 · Feb 14, 2019
commit 3039f631746f13b4decd407e8bd25edfca04489d
diff --git a/src/Symfony/Component/Console/Input/ArgvInput.php b/src/Symfony/Component/Console/Input/ArgvInput.php
@@ -294,7 +294,7 @@ public function hasParameterOption($values, $onlyParams = false)
    /**
     * {@inheritdoc}
     */
-    public function getParameterOption($values, $default = false, $onlyParams = false)
+    public function getParameterOption($values, $default = false, $onlyParams = false, $consume = false)
    {
        $values = (array) $values;
        $tokens = $this->tokens;

diff --git a/src/Symfony/Component/Console/Input/InputInterface.php b/src/Symfony/Component/Console/Input/InputInterface.php
@@ -54,10 +54,11 @@ public function hasParameterOption($values, $onlyParams = false);
     * @param string|array $values     The value(s) to look for in the raw parameters (can be an array)
     * @param mixed        $default    The default value to return if no result is found
     * @param bool         $onlyParams Only check real parameters, skip those following an end of options (--) signal
+     * @param bool         $consume    If true, the corresponding parameter will be removed from the instance
     *
     * @return mixed The option value
     */
-    public function getParameterOption($values, $default = false, $onlyParams = false);
+    public function getParameterOption($values, $default = false, $onlyParams = false, $consume = false);

    /**
     * Binds the current Input instance with the given arguments and options.
-Original file line number
+Diff line change
@@ -294,7 +294,7 @@ public function hasParameterOption($values, $onlyParams = false)
         /**
          * {@inheritdoc}
          */
-        public function getParameterOption($values, $default = false, $onlyParams = false)
+        public function getParameterOption($values, $default = false, $onlyParams = false, $consume = false)
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            nicolas-grekas
  

      

      

      


        Feb 14, 2019


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Only this class should be changed: all the other changes should be reverted as they are unneeded BC breaks.

On this class, the argument should be commented, mentionned in the docblock and accessed using func_get_arg().

See eg https://github.com/symfony/symfony/pull/30212/files#diff-94f4ef2d14dbabcc4f9c798fea31defbR350
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
         {
             $values = (array) $values;
             $tokens = $this->tokens;
-          Expand Down