Fix KernelTestCase compatibility for PhpUnit 8 (bis) #30124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1647a11 to
0ed30bb
Compare
OskarStark
approved these changes
Feb 9, 2019
0ed30bb to
d18a2d8
Compare
vudaltsov
reviewed
Feb 9, 2019
src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCaseTrait.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Feb 9, 2019
src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCaseTrait.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Feb 9, 2019
src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCaseTrait.php
Outdated
Show resolved
Hide resolved
d18a2d8 to
8324cd6
Compare
|
Comments addressed, thanks for the review. |
vudaltsov
approved these changes
Feb 10, 2019
Taluu
approved these changes
Feb 10, 2019
src/Symfony/Bundle/FrameworkBundle/Test/KernelShutdownOnTearDownTrait.php
Show resolved
Hide resolved
xabbuh
approved these changes
Feb 10, 2019
DanielBadura
approved these changes
Feb 11, 2019
ogizanagi
approved these changes
Feb 12, 2019
fabpot
approved these changes
Feb 12, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
…las-grekas) This PR was squashed before being merged into the 3.4 branch (closes #30124). Discussion ---------- Fix KernelTestCase compatibility for PhpUnit 8 (bis) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #30084 and @Tobion's comment there. Fabbot failure is a false-positive. Commits ------- 1077df6 Fix KernelTestCase compatibility for PhpUnit 8 (bis)
This was referenced Feb 24, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Feb 24, 2019
…arDownTrait (skalpa) This PR was merged into the 4.2 branch. Discussion ---------- [FrameworkBundle] Removed eval() from KernelShutdownOnTearDownTrait | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Apart from triggering the #30362 bug, the `eval()` block from #30124 also broke my workflow: static code analyzers don't like this, and the trait even crashes PHPStan. It may also bring up other compatibility issues to other people (ie: I know companies that completely disable `eval()` on their servers). As it was only required to keep the trait compatible with PHP 5.x, it is unnecessary on 4.x that requires PHP 7.1+, and this PR removes it on the 4.2 branch. Commits ------- 324b70a Removed eval() from KernelShutdownOnTearDownTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #30084 and @Tobion's comment there.
Fabbot failure is a false-positive.