Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Workflow] Graphviz dumper escape not always a string #30102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2019
Merged

[Workflow] Graphviz dumper escape not always a string #30102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
escape function does not always take a string
  • Loading branch information
@Korbeil
Korbeil committed Feb 7, 2019
commit 1b17192b0a976a16b3e3ea470cef776ab0c0b113
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Workflow/Dumper/GraphvizDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ protected function dotize($id)
/**
* @internal
*/
protected function escape(string $string): string
protected function escape($value): string
lyrixx marked this conversation as resolved.
Show resolved Hide resolved
{
return addslashes($string);
return \is_bool($value) ? ($value ? '1' : '0') : \addslashes($value);
}

private function addAttributes(array $attributes): string
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.