[FrameworkBundle] consolidate the mime types service definition #30001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6a5fab to
8abf6ce
Compare
|
|
8abf6ce to
882f5b8
Compare
|
Okay, makes sense somehow. But I think we should then move the |
xabbuh
commented
Feb 5, 2019
src/Symfony/Bundle/FrameworkBundle/Resources/config/mime_type.xml
Outdated
Show resolved
Hide resolved
882f5b8 to
c5ef9d9
Compare
nicolas-grekas
approved these changes
Feb 8, 2019
c5ef9d9 to
ce546f5
Compare
chalasr
approved these changes
Feb 11, 2019
fabpot
approved these changes
Feb 12, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
…inition (xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] consolidate the mime types service definition | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I wonder if we couldn't simplify things by just initializing the default `MimeTypes` instance once the first one is going to be created. Commits ------- ce546f5 consolidate the mime types service definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if we couldn't simplify things by just initializing the default
MimeTypesinstance once the first one is going to be created.