Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Avoid dots in generated class names #29922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29921
License MIT
Doc PR N/A

This PR removes dots from class names containers generated out of anonymous kernel classes.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On one line please :)

@derrabus derrabus force-pushed the bugfix/anonymous-class-name branch from a8875a5 to 52c80e6 Compare January 19, 2019 16:51
@derrabus
Copy link
Member Author

Done.

@fabpot
Copy link
Member

fabpot commented Jan 20, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 52c80e6 into symfony:4.2 Jan 20, 2019
fabpot added a commit that referenced this pull request Jan 20, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

Avoid dots in generated class names

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29921
| License       | MIT
| Doc PR        | N/A

This PR removes dots from class names containers generated out of anonymous kernel classes.

Commits
-------

52c80e6 Avoid dots in generated class names.
@derrabus derrabus deleted the bugfix/anonymous-class-name branch January 21, 2019 10:06
@fabpot fabpot mentioned this pull request Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.