[Cache] PDO-based cache pool table autocreation does not work #29900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @errogaht thanks for the PR, it looks good to me. |
c03b335 to
81d3716
Compare
|
Thank you @errogaht. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 25, 2019
…ork (errogaht) This PR was merged into the 4.2 branch. Discussion ---------- [Cache] PDO-based cache pool table autocreation does not work look at #29898 I believe that it is not good fix... But pgsq table not foutd throwed right there, in execute(). Dont know about another DB drivers, and i dont know will execute() again work or not, please if some one know more about PDO than me, check it! | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29898 | License | MIT Commits ------- 81d3716 [Cache] PDO-based cache pool table autocreation does not work
|
Actually, some db engine (eg sqlite) check table existency at prepare time, as spotted by the CI. I'm adding back the removed code. |
|
Ok I will modify code
пт, 25 янв. 2019 г. в 17:55, Nicolas Grekas <notifications@github.com>:
… Actually, some db engine (eg sqlite) check table existency at prepare
time, as spotted by the CI. I'm adding back the remove code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29900 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGCAKUlcXi6MJKkiOHW6rR-QF5Uz2i07ks5vGxrpgaJpZM4aCd2I>
.
|
|
@nicolas-grekas fixed, please check #30005 |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 1, 2019
…ecute (bendavies) This PR was merged into the 4.2 branch. Discussion ---------- [Cache] fix pruning pdo cache for vendors that throw on execute | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no > | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This additionally fixes pruning of the PdoAdapter when the table does not exist. Similar to #29900 #30005 and f419851 Commits ------- 14b9fa5 fix pruning pdo cache for vendors that throw on execute
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
look at #29898
I believe that it is not good fix... But pgsq table not foutd throwed right there, in execute(). Dont know about another DB drivers, and i dont know will execute() again work or not, please if some one know more about PDO than me, check it!