[BrowserKit] marked Response as @Final

symfony · fabpot · Jan 14, 2019 · Jan 14, 2019 · Jan 14, 2019 · Jan 14, 2019
commit 9045a4e580d3ff1316831ac8cb78d3bfb1dce87d
diff --git a/UPGRADE-4.3.md b/UPGRADE-4.3.md
@@ -4,6 +4,7 @@ UPGRADE FROM 4.2 to 4.3
 BrowserKit
 ----------

+ * Marked `Response` final.
 * Deprecated `Response::buildHeader()`
 * Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead


diff --git a/UPGRADE-5.0.md b/UPGRADE-5.0.md
@@ -4,6 +4,7 @@ UPGRADE FROM 4.x to 5.0
 BrowserKit
 ----------

+ * Removed the possibility to extend `Response` by making it final.
 * Removed `Response::buildHeader()`
 * Removed `Response::getStatus()`, use `Response::getStatusCode()` instead
 * The `Client::submit()` method has a new `$serverParameters` argument.

diff --git a/src/Symfony/Component/BrowserKit/CHANGELOG.md b/src/Symfony/Component/BrowserKit/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 4.3.0
 -----

+ * Marked `Response` final.
 * Deprecated `Response::buildHeader()`
 * Deprecated `Response::getStatus()`, use `Response::getStatusCode()` instead


diff --git a/src/Symfony/Component/BrowserKit/Response.php b/src/Symfony/Component/BrowserKit/Response.php
@@ -13,11 +13,16 @@

 /**
 * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @final since Symfony 4.3
 */
 class Response
 {
+    /** @internal */
    protected $content;
+    /** @internal */
    protected $status;
+    /** @internal */
    protected $headers;

    /**
-Original file line number
+Diff line change
@@ -13,11 +13,16 @@
     /**
      * @author Fabien Potencier <fabien@symfony.com>
+     *
+     * @final since Symfony 4.3
      */
     class Response
     {
+        /** @internal */
             Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            fabpot
  

      

      

      


        Jan 14, 2019


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      @final is enough, just to be extra clear.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
         protected $content;
+        /** @internal */
         protected $status;
+        /** @internal */
         protected $headers;
         /**
-          Expand Down