Grammar fix in exception message #29868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jan 13, 2019
|
Looks like it should be done on 3.4 |
|
@fabpot Yes, this week 👍 |
OskarStark
approved these changes
Jan 14, 2019
|
@xabbuh Sorry, I'm not able. Can you help me? I wanted to rebase (never did that) with: --> the rebase tells me that there are confilcts (the first one in src/Symfony/Component/Console/Helper/SymfonyQuestionHelper.php) and I have to merge. This seems wrong to me, what am I doing wrong? |
|
@michaelKaefer I did a rebase. :) |
According to https://en.wiktionary.org/wiki/whitespace and https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace valid sentences would be: - Whitespace is ... - Whitespaces are ... - Whitespace characters are ... But this is not correct: - Whitespace are ...
fabpot
approved these changes
Jan 21, 2019
|
Good catch, thanks @michaelKaefer. |
fabpot
added a commit
that referenced
this pull request
Jan 21, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Grammar fix in exception message According to https://en.wiktionary.org/wiki/whitespace and https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace valid sentences would be: - Whitespace is ... - Whitespaces are ... - Whitespace characters are ... But this is not correct: - Whitespace are ... | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 6e279a0 Grammar fix in exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://en.wiktionary.org/wiki/whitespace and https://english.stackexchange.com/questions/25368/what-is-the-plural-form-of-whitespace valid sentences would be:
But this is not correct: