Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[PropertyAccess] remove doubled dot from exception message #29791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Jan 5, 2019
Merged

[PropertyAccess] remove doubled dot from exception message #29791

fabpot merged 1 commit into from
Jan 5, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 5, 2019

Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.1 milestone Jan 5, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Jan 5, 2019

The terminating dot is already contained in $access[self::ACCESS_NAME] (see https://github.com/symfony/symfony/blob/v4.1.9/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L471, https://github.com/symfony/symfony/blob/v4.1.9/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L646 and https://github.com/symfony/symfony/blob/v4.1.9/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L656).

ogizanagi
ogizanagi approved these changes Jan 5, 2019
View reviewed changes
src/Symfony/Component/PropertyAccess/PropertyAccessor.php Outdated Show resolved Hide resolved
@xabbuh xabbuh force-pushed the remove-double-dot branch from 1bf9f59 to 4c04328 Compare January 5, 2019 11:52
@fabpot
Copy link
Member

fabpot commented Jan 5, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 4c04328 into symfony:4.1 Jan 5, 2019
fabpot added a commit that referenced this pull request Jan 5, 2019
@fabpot
minor #29791 [PropertyAccess] remove doubled dot from exception messa…
96b962d 
…ge (xabbuh)

This PR was merged into the 4.1 branch.

Discussion
----------

[PropertyAccess] remove doubled dot from exception message

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

4c04328 remove doubled dot from exception message
@xabbuh xabbuh deleted the remove-double-dot branch January 5, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

+1 more reviewer

@ogizanagi ogizanagi ogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PropertyAccess Status: Reviewed

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh @fabpot @ogizanagi @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.