Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DI] Dump container with HTTPS xsd #29789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DI] Dump container with HTTPS xsd #29789

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jan 5, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29775
License MIT
Doc PR symfony/symfony-docs#...

@ro0NL ro0NL changed the title Update XSD schema location to HTTPS [DI] Dump container with HTTPS xsd Jan 5, 2019
@dunglas
Copy link
Member

dunglas commented Jan 7, 2019

The fix looks appropriated (and using HTTPS is always better), but the tests must be updated.

@ro0NL
Copy link
Contributor Author

ro0NL commented Jan 8, 2019

right :) i dont want to add unnecessary effort for mergers. So perhaps it's better to do it globally per branch, 3.4 and up, or keep the legacy.

sed -i -E 's/http:\/\/symfony.com\/schema\/dic\/([^\ ]+)\.xsd/https:\/\/symfony.com\/schema\/dic\/\1.xsd/g' src/**/*.{xml,php}

@stof
Copy link
Member

stof commented Jan 9, 2019

this should indeed be done in 3.4 and up to avoid merge conflicts in the future.

@xabbuh xabbuh added this to the 3.4 milestone Jan 10, 2019
@ro0NL
Copy link
Contributor Author

ro0NL commented Jan 10, 2019

i was mainly curious if we we want to update all test fixtures and core configs as well...

if it's only for the dumped container, it also qualifies a new feature (but i should fix the tests properly, per case then)

@chalasr
Copy link
Member

chalasr commented Jan 10, 2019

I would update core configs as well. For testing configs I think we don't really care, would be bonus :)

@nicolas-grekas
Copy link
Member

(rebase needed)

@fabpot fabpot mentioned this pull request Mar 4, 2019
@fabpot
Copy link
Member

fabpot commented Mar 4, 2019

see #30434

@fabpot fabpot closed this Mar 4, 2019
@ro0NL ro0NL deleted the xsd branch March 4, 2019 10:08
fabpot added a commit that referenced this pull request Mar 4, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

moved XSD to HTTPS

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | closes #29775 closes #29789
| License       | MIT
| Doc PR        | n/a

Commits
-------

95e90b8 moved XSD to HTTPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.