Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] Fix FormDefaultChoiceListFactory test #29769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vudaltsov
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29731 (review)
License MIT
Doc PR n/a

$groupBy is either null or callable. Passing array() is wrong.

@fabpot
Copy link
Member

fabpot commented Jan 4, 2019

Thank you @vudaltsov.

@fabpot fabpot merged commit b8f6390 into symfony:3.4 Jan 4, 2019
fabpot added a commit that referenced this pull request Jan 4, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fix FormDefaultChoiceListFactory test

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29731 (review)
| License       | MIT
| Doc PR        | n/a

`$groupBy` is either `null` or `callable`. Passing `array()` is wrong.

Commits
-------

b8f6390 Fixed groupBy argument value in DefaultChoiceListFactoryTest
@vudaltsov vudaltsov deleted the form-default-choice-list-factory-test branch January 4, 2019 18:10
@vudaltsov
Copy link
Contributor Author

Thank you! Waiting for merges into upper branches, so I can rebase #29731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.