Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[tests] refactor will/with mock calls to specific alternatives #29740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[tests] refactor will/with mock calls to specific alternatives #29740

wants to merge 1 commit into from

Conversation

TomasVotruba
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
License MIT

Mirror to #29685, covering more cases, automated.

@gmponos Could you briefly review if changes are correct?

Feel free try Rector locally:

# rector.yml
parameters:
    exclude_paths:
        - "/tests/"
        - "/Fixtures/"
        # autoload-buggy cases
        - "*TransformerTest.php"
        - "*TestRunnerForV6.php"
        - "*FactoryV1.php"
        - "*CollectorTest.php"
        - "*ValidatorTest.php"

services:
    Rector\PHPUnit\Rector\MethodCall\UseSpecificWillMethodRector: ~

Better separate runs over standalone dirs, since it's quite performance heavy.

vendor/bin/rector process src/Symfony/Bridge
vendor/bin/rector process src/Symfony/Bundles
vendor/bin/rector process src/Symfony/Components

This was referenced Dec 31, 2018
Closed
Closed
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 3, 2019
@nicolas-grekas
Copy link
Member

Same comment as on #29685:
I'm going to close as this is a time-consuming PR with little practical benefits. Generally speaking, all CS-related fixes should come via automated rules implemented in php-cs-fixer, to minimize the effort of maintainers.
Thanks for opening anyway!

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 3, 2019 •
edited
Loading

Sure 👍 I care about automatization of this task, wherever it will be performed. It's perfect use case for AST automatization and does the maintainer job as well.

@TomasVotruba TomasVotruba deleted the 3.4-tests-will-with branch January 3, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasVotruba @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.