[Tests] Change to willThrowException #29672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e581f02 to
0695834
Compare
|
Thank you @gmponos. |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2018
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29672). Discussion ---------- [Tests] Change to willThrowException | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Trivial changes of `will($this->throwException());` to `willThrowException();` Do you think it's worth it ti create a PR to change `->will($this->returnValue());` Commits ------- 0695834 [Tests] Change to willThrowException
@fabpot I saw that you created a related issue to Until then would you accept a PR for that or is it an overhead and will cause conficts.. (there are hundred of changes) One more thing that I've noticed on tests is this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial changes of
will($this->throwException());towillThrowException();Do you think it's worth it ti create a PR to change
->will($this->returnValue());