Allow running PHPUnit with "xdebug.scream" ON #29645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 18, 2018
| @@ -743,7 +743,10 @@ protected function dumpContainer(ConfigCache $cache, ContainerBuilder $container | ||
| $fs->dumpFile($dir.$file, $code); | ||
| @chmod($dir.$file, 0666 & ~umask()); | ||
| } | ||
| @unlink(\dirname($dir.$file).'.legacy'); | ||
| $legacyFile = \dirname($dir.$file).'.legacy'; | ||
| if (\file_exists($legacyFile)) { |
There was a problem hiding this comment.
please remove the \ here (but keep it for dirname)
There was a problem hiding this comment.
absolutely, I've found a mix of both in the codebase so didn't know which was the preferred one. all done now
334fbe1 to
f974e7c
Compare
azjezz
approved these changes
Dec 19, 2018
Since symfony#25733 the Kernel attempts to unlink the legacy container while being built. This throws an error if the file did not exist, for example on a clean install, on the build, which is then silenced. That's fine on production systems, but on our build we have enabled "xdebug.scream" in order to visualise every errors, which basically un-silences the errors. I believe there should not be a need to silence anything on a usual, clean usage of the system. Making this `unlink` conditional fixes it. Could you please approve and merge this PR? Thanks
f974e7c to
7a7165e
Compare
|
Thank you @nico-incubiq. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 19, 2018
…biq) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29645). Discussion ---------- Allow running PHPUnit with "xdebug.scream" ON | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> Since #25733 the Kernel attempts to unlink the legacy container while being built. This throws an error if the file did not exist, for example on a clean install, on the build, which is then silenced. That's fine on production systems, but on our build we have enabled `xdebug.scream` in order to visualise every errors, which basically un-silences the errors. I believe there should not be a need to silence anything on a usual, clean usage of the system. Making this `unlink` conditional fixes it. Could you please approve and merge this PR? Thanks Commits ------- 7a7165e Allow running PHPUnit with "xdebug.scream" ON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #25733 the Kernel attempts to unlink the legacy container while being built.
This throws an error if the file did not exist, for example on a clean install, on the build, which is then silenced.
That's fine on production systems, but on our build we have enabled
xdebug.screamin order to visualise every errors, which basically un-silences the errors. I believe there should not be a need to silence anything on a usual, clean usage of the system.Making this
unlinkconditional fixes it.Could you please approve and merge this PR?
Thanks