Enable PHP 7.3 on Travis #29624

tvlooy · Dec 16, 2018

Enable PHP 7.3 on Travis.

nicolas-grekas · Dec 17, 2018

I see you took my commit from nicolas-grekas#18, cool!
Thanks for giving it a try!

tvlooy · Dec 17, 2018

@nicolas-grekas what's the best way to trigger travis builds?

nicolas-grekas · Dec 17, 2018

push-forcing a commit - but maybe the yaml is invalid? that could be a reason why travis is not triggered.

Kocal · Dec 17, 2018

A new way (RIP https://lint.travis-ci.org) to lint your .travis.yml is to use the Travis CI CLI.
Maybe run travis lint in the Symfony repo can help you?

rpkamp · Dec 17, 2018

PR ran in Travis. I'm not sure why it's not reported in GitHub though. Weird.

https://travis-ci.org/symfony/symfony/builds/468787659

rpkamp · Dec 17, 2018

It did run for older commits, but then stopped working. Must be something wrong with travis.yaml indeed.

rpkamp · Dec 17, 2018

Just ran travis cli lint and the offending line is this one: https://github.com/symfony/symfony/pull/29624/files#diff-354f30a63fb0907d4ad57269548329e3R195

When you remove that line or indent it properly Travis lint is fine with the YAML.

Should be

      if [[ ! $skip ]]; then
          # ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/base.ldif &&
          ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/fixtures.ldif
      fi

instead of

      if [[ ! $skip ]]; then
#         ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/base.ldif &&
          ldapadd -h localhost:3389 -D cn=admin,dc=symfony,dc=com -w symfony -f src/Symfony/Component/Ldap/Tests/Fixtures/data/fixtures.ldif
      fi

tvlooy · Dec 17, 2018

ok great! we now have some failing tests to look at

stof · Dec 18, 2018

.travis.yml

@@ -126,6 +126,26 @@ before_install:
          (cd php-$MIN_PHP && ./configure --enable-sigchild --enable-pcntl && make -j2)
      fi

+    - |
+      # Install ext/memcached from source


shouldn't it be done only for PHP 7.3 ?

yes that's true. Maybe it's even better to compile the .so files once and download them instead of compiling (until a release is made) because these are master branches ...
I would first like to get to the point where 7.3 is working. Any idea to fix the OPT_LIBKETAMA_COMPATIBLE issue? I am a bit lost

Memcached should be in its way before the end of the year.

php-memcached-dev/php-memcached#408 (comment)

okay. Trying to isolate the memcache tests now ...

tvlooy · Dec 20, 2018

the memcached behavior is reproducible with 7.2. Can't reproduce locally so have to trigger more Travis builds to find the exact commit in ext/memcached that behaves different

tvlooy · Dec 20, 2018

enabled amqp now

tvlooy · Dec 20, 2018

Status of the work is kept up to date in the PR description above. @nicolas-grekas ext/memcached is skipped for now, ext/amqp is built from source. The tests are green https://travis-ci.org/symfony/symfony/builds/470724643

rpkamp · Dec 21, 2018

I admire your persistence @tvlooy!

tvlooy · Dec 21, 2018

Puzzled with the failing memcached tests

tvlooy · Jan 16, 2019

well that works. Yay!

ping @nicolas-grekas @stof

nicolas-grekas · Jan 16, 2019

Awesome thank you!

fabpot · Jan 17, 2019

.travis.yml

-          env: deps=low
+          env: deps=high
+        - php: 7.3
+          env: deps=high


Looks like we don't have test for deps=low anymore.

which envs do you want to test? I enabled all in next commit but that seems overkill

This PR was merged into the 3.4 branch. Discussion ---------- Enable PHP 7.3 on Travis | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The bits of #29624 that apply to 3.4. Commits ------- 335036c Enable PHP 7.3 on Travis

nicolas-grekas · Jan 24, 2019

Merged on 3.4 in #29979
There is still something to improve: compiling memcached.so almost double the job time, by taking 6 minutes. But the .so file could be cached.
@tvlooy would you like to work on that? (it should target 3.4)

tvlooy · Jan 25, 2019

@nicolas-grekas good idea. I'll try to do it this week

This PR was merged into the 3.4 branch. Discussion ---------- Use system wide memcached.so | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | WiP | License | MIT requested by #29624 (comment) let's see what travis is going to do with this ... Commits ------- 8d171f4 Use system wide memcached.so

carsonbot added the Status: Needs Review label Dec 16, 2018

tvlooy changed the title ~~Enable PHP 7.3 on Travis~~ WIP: Enable PHP 7.3 on Travis Dec 16, 2018

tvlooy mentioned this pull request Dec 16, 2018

PHP 7.3 support #29579

Closed

stof reviewed Dec 18, 2018

View reviewed changes

tvlooy mentioned this pull request Dec 20, 2018

Fix: Segfault when creating keys php-zookeeper/php-zookeeper#31

Closed

tvlooy changed the title ~~WIP: Enable PHP 7.3 on Travis~~ Enable PHP 7.3 on Travis Dec 20, 2018

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jan 17, 2019

fabpot requested changes Jan 17, 2019

View reviewed changes

tvlooy added 4 commits January 18, 2019 18:34

Enable PHP 7.3 on Travis

1be6505

docs

a6cb39d

Push deps

5c264aa

Enable all envs

4085343

This was referenced Jan 24, 2019

Enable PHP 7.3 on Travis #29978

Closed

Enable PHP 7.3 on Travis #29979

Merged

nicolas-grekas closed this Jan 24, 2019

tvlooy deleted the php73 branch January 29, 2019 20:39

tvlooy mentioned this pull request Jan 29, 2019

Use system wide memcached.so #30030

Merged

Search code, repositories, users, issues, pull requests...

Uh oh!

Enable PHP 7.3 on Travis #29624

Enable PHP 7.3 on Travis #29624

Uh oh!

Conversation

tvlooy commented Dec 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas commented Dec 17, 2018

Uh oh!

tvlooy commented Dec 17, 2018

Uh oh!

nicolas-grekas commented Dec 17, 2018

Uh oh!

Kocal commented Dec 17, 2018

Uh oh!

rpkamp commented Dec 17, 2018

Uh oh!

rpkamp commented Dec 17, 2018

Uh oh!

rpkamp commented Dec 17, 2018

Uh oh!

tvlooy commented Dec 17, 2018

Uh oh!

stof Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

tvlooy Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

OskarStark Dec 19, 2018

Choose a reason for hiding this comment

Uh oh!

tvlooy Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

tvlooy commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvlooy commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tvlooy commented Dec 20, 2018

Uh oh!

rpkamp commented Dec 21, 2018

Uh oh!

tvlooy commented Dec 21, 2018

Uh oh!

tvlooy commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolas-grekas commented Jan 16, 2019

Uh oh!

fabpot Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

tvlooy Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jan 24, 2019

Uh oh!

tvlooy commented Jan 25, 2019

Uh oh!

Uh oh!

tvlooy commented Dec 16, 2018 •

edited

Loading

tvlooy commented Dec 20, 2018 •

edited

Loading

tvlooy commented Dec 20, 2018 •

edited

Loading

tvlooy commented Jan 16, 2019 •

edited

Loading