Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PropertyAccess] make cache keys encoding bijective #29332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29329 (comment)
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 26, 2018
@nicolas-grekas nicolas-grekas changed the title [PropertyAccess] make cache key encoding bijective [PropertyAccess] make cache keys encoding bijective Nov 26, 2018
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unit test would be great :)

@nicolas-grekas nicolas-grekas merged commit 4fe566b into symfony:3.4 Nov 26, 2018
nicolas-grekas added a commit that referenced this pull request Nov 26, 2018
…as-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[PropertyAccess] make cache keys encoding bijective

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29329 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

4fe566b [PropertyAccess] make cache keys encoding bijective
@nicolas-grekas nicolas-grekas deleted the pa-enc branch November 26, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.