[Routing] Remove duplicate schemes and methods for invokable controllers #29225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
suggested changes
Nov 15, 2018
Tobion
reviewed
Nov 17, 2018
| $globals['path'] = ''; | ||
| $globals['name'] = ''; | ||
| $globals['localized_paths'] = array(); | ||
| $globals = $this->resetGlobals(); |
There was a problem hiding this comment.
please move this call outside the foreach as it does not need to be done foreach annotation
|
Could you open this against the 3.4 branch as the bug is also in there. |
|
As I said, please open a new PR against 3.4 or rebase this one. In 3.4 it's slightly different as |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2018
…le controllers (claudusd) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] Remove duplicate schemes and methods for invokable controllers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29225 | License | MIT This PR backport for 3.4 branch the same issue than the PR #29225. I add a test to check the fix when annotation are on the class and rename another one when the route annotation is on the invoke method. Commits ------- 640ccdf [Routing] Remove duplicate schemes and methods for invokable controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When we use annotation for invokable controller the http's methods and schemes are duplicate in
Routeinstance.This duplicity doesn't make bug but when we use
bin/console debug:routerthe path's method and scheme are print twice.To reproduce :
bin/console debug:router