-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Added a context to Workflow::apply()
#29146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
src/Symfony/Component/Workflow/MarkingStore/MethodMarkingStore.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Workflow\MarkingStore; | ||
|
|
||
| use Symfony\Component\Workflow\Exception\LogicException; | ||
| use Symfony\Component\Workflow\Marking; | ||
|
|
||
| /** | ||
| * MethodMarkingStore stores the marking with a subject's method. | ||
| * | ||
| * This store deals with a "single state" or "multiple state" Marking. | ||
| * | ||
| * @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
| */ | ||
| class MethodMarkingStore implements MarkingStoreInterface | ||
| { | ||
| private $singleState; | ||
| private $property; | ||
|
|
||
| /** | ||
| * @param string $property Used to determine methods to call | ||
| * The `getMarking` method will use `$subject->getProperty()` | ||
| * The `setMarking` method will use `$subject->setProperty(string|array $places, array $context = array())` | ||
| */ | ||
lyrixx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public function __construct(bool $singleState = false, string $property = 'marking') | ||
| { | ||
| $this->singleState = $singleState; | ||
| $this->property = $property; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getMarking($subject) | ||
| { | ||
| $method = 'get'.ucfirst($this->property); | ||
lyrixx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (!method_exists($subject, $method)) { | ||
| throw new LogicException(sprintf('The method "%s::%s()" does not exists.', \get_class($subject), $method)); | ||
| } | ||
|
|
||
| $marking = $subject->{$method}(); | ||
|
|
||
| if (!$marking) { | ||
| return new Marking(); | ||
| } | ||
|
|
||
| if ($this->singleState) { | ||
| $marking = [$marking => 1]; | ||
| } | ||
|
|
||
| return new Marking($marking); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setMarking($subject, Marking $marking, array $context = []) | ||
| { | ||
| $marking = $marking->getPlaces(); | ||
|
|
||
| if ($this->singleState) { | ||
| $marking = key($marking); | ||
| } | ||
|
|
||
| $method = 'set'.ucfirst($this->property); | ||
|
|
||
| if (!method_exists($subject, $method)) { | ||
| throw new LogicException(sprintf('The method "%s::%s()" does not exists.', \get_class($subject), $method)); | ||
| } | ||
|
|
||
| $subject->{$method}($marking, $context); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
src/Symfony/Component/Workflow/Tests/MarkingStore/MethodMarkingStoreTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <?php | ||
|
|
||
| namespace Symfony\Component\Workflow\Tests\MarkingStore; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\Workflow\Marking; | ||
| use Symfony\Component\Workflow\MarkingStore\MethodMarkingStore; | ||
|
|
||
| class MethodMarkingStoreTest extends TestCase | ||
| { | ||
| public function testGetSetMarkingWithMultipleState() | ||
| { | ||
| $subject = new Subject(); | ||
|
|
||
| $markingStore = new MethodMarkingStore(false); | ||
|
|
||
| $marking = $markingStore->getMarking($subject); | ||
|
|
||
| $this->assertInstanceOf(Marking::class, $marking); | ||
| $this->assertCount(0, $marking->getPlaces()); | ||
|
|
||
| $marking->mark('first_place'); | ||
|
|
||
| $markingStore->setMarking($subject, $marking); | ||
|
|
||
| $this->assertSame(['first_place' => 1], $subject->getMarking()); | ||
|
|
||
| $marking2 = $markingStore->getMarking($subject); | ||
|
|
||
| $this->assertEquals($marking, $marking2); | ||
| } | ||
|
|
||
| public function testGetSetMarkingWithSingleState() | ||
| { | ||
| $subject = new Subject(); | ||
|
|
||
| $markingStore = new MethodMarkingStore(true); | ||
|
|
||
| $marking = $markingStore->getMarking($subject); | ||
|
|
||
| $this->assertInstanceOf(Marking::class, $marking); | ||
| $this->assertCount(0, $marking->getPlaces()); | ||
|
|
||
| $marking->mark('first_place'); | ||
|
|
||
| $markingStore->setMarking($subject, $marking); | ||
|
|
||
| $this->assertSame('first_place', $subject->getMarking()); | ||
|
|
||
| $marking2 = $markingStore->getMarking($subject); | ||
|
|
||
| $this->assertEquals($marking, $marking2); | ||
| } | ||
| } | ||
|
|
||
| final class Subject | ||
| { | ||
| private $marking; | ||
|
|
||
| public function __construct($marking = null) | ||
| { | ||
| $this->marking = $marking; | ||
| } | ||
|
|
||
| public function getMarking() | ||
| { | ||
| return $this->marking; | ||
| } | ||
|
|
||
| public function setMarking($marking) | ||
| { | ||
| $this->marking = $marking; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.