[Intl] Update the ICU data to 63.1 #28977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a work in progress since I still have to make all the tests pass. |
ro0NL
reviewed
Oct 25, 2018
28507b8 to
06c45b4
Compare
jakzal
commented
Oct 26, 2018
...Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
Show resolved
Hide resolved
jakzal
commented
Oct 26, 2018
jakzal
commented
Oct 26, 2018
|
All tests passing. PR ready. |
|
@jakzal Thanks for working on this. I'm wondering if we could add your Github's comment directly as comments in the code. They are valuable and should be kept close to the code IMHO. WDYT? |
|
Good point. Added comments. |
fabpot
approved these changes
Oct 27, 2018
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Oct 27, 2018
This PR was squashed before being merged into the 3.4 branch (closes #28977). Discussion ---------- [Intl] Update the ICU data to 63.1 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - http://site.icu-project.org/download/63 All tests are passing on the CI. I additionally run intl related tests (Form,Intl,Translation,Validator components) with ICU `63.1` on PHP `5.5`, `5.6`, `7.1`, `7.2`, `7.3-rc`. Confirmed `@group intl-data` tests are passing with ICU `63.1` on PHP `5.5` and `7.2`. Commits ------- 76bc6f0 [Intl] Update the ICU data to 63.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://site.icu-project.org/download/63
All tests are passing on the CI. I additionally run intl related tests (Form,Intl,Translation,Validator components) with ICU
63.1on PHP5.5,5.6,7.1,7.2,7.3-rc.Confirmed
@group intl-datatests are passing with ICU63.1on PHP5.5and7.2.