[Config] Fix @method annotation #28915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Config/Definition/Builder/ParentNodeDefinitionInterface.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Oct 19, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2018
This PR was squashed before being merged into the 4.1 branch (closes #28915). Discussion ---------- [Config] Fix @method annotation | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> ``` @method [[static] return type] [name]([[type] [parameter]<, ...>]) [<description>] ``` I dont think this was intended to be the method description, which will be taken into account after #28902 Let me know if there's a better description, other then `Gets the child node definitions` :) Commits ------- 0d7a961 [Config] Fix @method annotation
fabpot
added a commit
that referenced
this pull request
Oct 19, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #28916). Discussion ---------- [Form] Fix @method annotation | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Same as #28915 for 4.2 (these are the only occurrences for interfaces) Actually provides a use case for #28902 (comment) 🎉 Commits ------- 13f0db7 [Form] Fix @method annotation
lyrixx
pushed a commit
to lyrixx/symfony
that referenced
this pull request
Oct 19, 2018
This PR was squashed before being merged into the 4.1 branch (closes symfony#28915). Discussion ---------- [Config] Fix @method annotation | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> ``` @method [[static] return type] [name]([[type] [parameter]<, ...>]) [<description>] ``` I dont think this was intended to be the method description, which will be taken into account after symfony#28902 Let me know if there's a better description, other then `Gets the child node definitions` :) Commits ------- 0d7a961 [Config] Fix @method annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont think this was intended to be the method description, which will be taken into account after #28902
Let me know if there's a better description, other then
Gets the child node definitions:)