Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Validator] Changed translation "epost-adress" to "e-postadress" #28822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 11, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I just saw this.

Could @nicholasruunu, @sunkan and/or @pmodin review this small change?

Copy link
Contributor

@nicholasruunu nicholasruunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sunkan
Copy link

sunkan commented Oct 11, 2018

Looks good +1

@fabpot fabpot changed the base branch from 3.4 to 2.8 October 11, 2018 17:17
@fabpot
Copy link
Member

fabpot commented Oct 11, 2018

Thank you @Nyholm.

@fabpot fabpot merged commit 91e3657 into symfony:2.8 Oct 11, 2018
fabpot added a commit that referenced this pull request Oct 11, 2018
…tadress" (Nyholm)

This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #28822).

Discussion
----------

[Validator] Changed translation "epost-adress" to "e-postadress"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I just saw this.

Could @nicholasruunu, @sunkan and/or @pmodin review this small change?

Commits
-------

91e3657 Changed "epost-adress" to "e-postadress"
@Nyholm Nyholm deleted the patch-5 branch October 11, 2018 17:24
@Nyholm
Copy link
Member Author

Nyholm commented Oct 11, 2018

Thank you for the quick reviews and the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.