Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CS fixes #28814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018
Merged

CS fixes #28814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 src/Symfony/Bridge/Doctrine/ContainerAwareEventManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public function __construct(ContainerInterface $container)
*
* @param string $eventName The name of the event to dispatch. The name of the event is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we then need to change the description here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but out of the scope of this PR. I just want the code to have 0 CS errors. If someone wants to improve the current description, they are more than welcome, but I would not see that as a priority.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I was just wondering why the fixer complained about one case while leaving the other untouched.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I don't understand why this is not fixed. /cc @SpacePossum @keradus

* the name of the method that is invoked on listeners.
* @param EventArgs $eventArgs The event arguments to pass to the event handlers/listeners.
* If not supplied, the single empty EventArgs instance is used.
* @param EventArgs $eventArgs the event arguments to pass to the event handlers/listeners.
* If not supplied, the single empty EventArgs instance is used
*
* @return bool
*/
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/EventDispatcher/ContainerAwareEventDispatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public function __construct(ContainerInterface $container)
* @param string $eventName Event for which the listener is added
* @param array $callback The service ID of the listener service & the method
* name that has to be called
* @param int $priority The higher this value, the earlier an event listener
* @param int $priority the higher this value, the earlier an event listener
* will be triggered in the chain.
* Defaults to 0.
* Defaults to 0
*
* @throws \InvalidArgumentException
*/
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Form/FormConfigBuilderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,10 @@ public function setRequestHandler(RequestHandlerInterface $requestHandler);
*
* Should be set to true only for root forms.
*
* @param bool $initialize True to initialize the form automatically,
* @param bool $initialize true to initialize the form automatically,
* false to suppress automatic initialization.
* In the second case, you need to call
* {@link FormInterface::initialize()} manually.
* {@link FormInterface::initialize()} manually
*
* @return $this The configuration object
*/
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Form/FormInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ public function getData();
/**
* Returns the normalized data of the field.
*
* @return mixed When the field is not submitted, the default data is returned.
* @return mixed when the field is not submitted, the default data is returned.
* When the field is submitted, the normalized submitted data is
* returned if the field is valid, null otherwise.
* returned if the field is valid, null otherwise
*/
public function getNormData();

Expand Down
12 changes: 6 additions & 6 deletions 12 src/Symfony/Component/Form/FormRendererEngineInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ public function setTheme(FormView $view, $themes);
* The type of the resource is decided by the implementation. The resource
* is later passed to {@link renderBlock()} by the rendering algorithm.
*
* @param FormView $view The view for determining the used themes.
* @param FormView $view the view for determining the used themes.
* First the themes attached directly to the
* view with {@link setTheme()} are considered,
* then the ones of its parent etc.
* then the ones of its parent etc
* @param string $blockName The name of the block to render
*
* @return mixed the renderer resource or false, if none was found
Expand Down Expand Up @@ -68,10 +68,10 @@ public function getResourceForBlockName(FormView $view, $blockName);
* The type of the resource is decided by the implementation. The resource
* is later passed to {@link renderBlock()} by the rendering algorithm.
*
* @param FormView $view The view for determining the used themes.
* @param FormView $view the view for determining the used themes.
* First the themes attached directly to
* the view with {@link setTheme()} are
* considered, then the ones of its parent etc.
* considered, then the ones of its parent etc
* @param array $blockNameHierarchy The block name hierarchy, with the root block
* at the beginning
* @param int $hierarchyLevel The level in the hierarchy at which to start
Expand Down Expand Up @@ -106,10 +106,10 @@ public function getResourceForBlockNameHierarchy(FormView $view, array $blockNam
* The type of the resource is decided by the implementation. The resource
* is later passed to {@link renderBlock()} by the rendering algorithm.
*
* @param FormView $view The view for determining the used themes.
* @param FormView $view the view for determining the used themes.
* First the themes attached directly to
* the view with {@link setTheme()} are
* considered, then the ones of its parent etc.
* considered, then the ones of its parent etc
* @param array $blockNameHierarchy The block name hierarchy, with the root block
* at the beginning
* @param int $hierarchyLevel The level in the hierarchy at which to start
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Form/Util/OrderedHashMapIterator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ class OrderedHashMapIterator implements \Iterator
* keys
* @param array $orderedKeys The keys of the map in the order in which
* they should be iterated
* @param array $managedCursors An array from which to reference the
* @param array $managedCursors an array from which to reference the
* iterator's cursor as long as it is alive.
* This array is managed by the corresponding
* {@link OrderedHashMap} instance to support
* recognizing the deletion of elements.
* recognizing the deletion of elements
*/
public function __construct(array &$elements, array &$orderedKeys, array &$managedCursors)
{
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NativeFileSessionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
class NativeFileSessionHandler extends NativeSessionHandler
{
/**
* @param string $savePath Path of directory to save session files
* @param string $savePath path of directory to save session files
* Default null will leave setting as defined by PHP.
* '/path', 'N;/path', or 'N;octal-mode;/path
*
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,9 @@ public function setPattern($pattern)
/**
* Set the formatter's timezone identifier.
*
* @param string $timeZoneId The time zone ID string of the time zone to use.
* @param string $timeZoneId the time zone ID string of the time zone to use.
* If NULL or the empty string, the default time zone for the
* runtime is used.
* runtime is used
*
* @return bool true on success or false on failure
*
Expand Down
16 changes: 8 additions & 8 deletions 16 src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ class NumberFormatter

/**
* @param string $locale The locale code. The only currently supported locale is "en" (or null using the default locale, i.e. "en")
* @param int $style Style of the formatting, one of the format style constants.
* @param int $style style of the formatting, one of the format style constants.
* The only supported styles are NumberFormatter::DECIMAL
* and NumberFormatter::CURRENCY.
* and NumberFormatter::CURRENCY
* @param string $pattern Not supported. A pattern string in case $style is NumberFormat::PATTERN_DECIMAL or
* NumberFormat::PATTERN_RULEBASED. It must conform to the syntax
* described in the ICU DecimalFormat or ICU RuleBasedNumberFormat documentation
Expand Down Expand Up @@ -279,9 +279,9 @@ public function __construct($locale = 'en', $style = null, $pattern = null)
* Static constructor.
*
* @param string $locale The locale code. The only supported locale is "en" (or null using the default locale, i.e. "en")
* @param int $style Style of the formatting, one of the format style constants.
* @param int $style style of the formatting, one of the format style constants.
* The only currently supported styles are NumberFormatter::DECIMAL
* and NumberFormatter::CURRENCY.
* and NumberFormatter::CURRENCY
* @param string $pattern Not supported. A pattern string in case $style is NumberFormat::PATTERN_DECIMAL or
* NumberFormat::PATTERN_RULEBASED. It must conform to the syntax
* described in the ICU DecimalFormat or ICU RuleBasedNumberFormat documentation
Expand Down Expand Up @@ -340,8 +340,8 @@ public function formatCurrency($value, $currency)
* Format a number.
*
* @param int|float $value The value to format
* @param int $type Type of the formatting, one of the format type constants.
* Only type NumberFormatter::TYPE_DEFAULT is currently supported.
* @param int $type type of the formatting, one of the format type constants.
* Only type NumberFormatter::TYPE_DEFAULT is currently supported
*
* @return bool|string The formatted value or false on error
*
Expand Down Expand Up @@ -547,9 +547,9 @@ public function parse($value, $type = self::TYPE_DOUBLE, &$position = 0)
/**
* Set an attribute.
*
* @param int $attr An attribute specifier, one of the numeric attribute constants.
* @param int $attr an attribute specifier, one of the numeric attribute constants.
* The only currently supported attributes are NumberFormatter::FRACTION_DIGITS,
* NumberFormatter::GROUPING_USED and NumberFormatter::ROUNDING_MODE.
* NumberFormatter::GROUPING_USED and NumberFormatter::ROUNDING_MODE
* @param int $value The attribute value
*
* @return bool true on success or false on failure
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.