[CS] Enable phpdoc_types_order #28780
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
approved these changes
Oct 9, 2018
julienfalque
reviewed
Oct 9, 2018
| @@ -19,6 +19,7 @@ return PhpCsFixer\Config::create() | ||
| 'self_accessor' => false, | ||
| // Part of @Symfony:risky in PHP-CS-Fixer 2.13.0. To be removed from the config file once upgrading | ||
| 'native_function_invocation' => array('include' => array('@compiler_optimized'), 'scope' => 'namespaced'), | ||
| 'phpdoc_types_order' => array('null_adjustment' => 'always_last', 'sort_algorithm' => 'none'), |
There was a problem hiding this comment.
Note that the comment above is misleading: the rule isn't part of any ruleset for now. Do you mind submitting a PR on PHP CS Fixer to update the Symfony ruleset?
There was a problem hiding this comment.
@julienfalque What branch in PHP-CS-Fixer should I send? :)
There was a problem hiding this comment.
Rulesets updates are done on minor releases so you should target branch master.
There was a problem hiding this comment.
@julienfalque Cool. Gonna update the comment here for now, as well, submit a patch for the ruleset in php-cs-fixer 😊
javiereguiluz
approved these changes
Oct 11, 2018
|
Thank you @carusogabriel. |
fabpot
added a commit
that referenced
this pull request
Oct 11, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [CS] Enable phpdoc_types_order | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - As suggested by @jvasseur in #28675 (comment), we can use the `phpdoc_types_order` rule from PHP-CS-Fixer to ensure that `null` is always on the last position in phpDocs as proposed in #28675. Commits ------- c340502 [CS] Enable phpdoc_types_order
SpacePossum
added a commit
to PHP-CS-Fixer/PHP-CS-Fixer
that referenced
this pull request
Oct 18, 2018
…abriel) This PR was merged into the 2.14-dev branch. Discussion ---------- Add phpdoc_types_order rule to Symfony's ruleset As suggested by @julienfalque in symfony/symfony#28780, besides add this new rule due to symfony/symfony#28675, we should also enforces it in Symfony's ruleset here too 😊 Commits ------- c2ccec2 Add phpdoc_types_order rule to Symfony's ruleset
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 12, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [standards] Document "phpdoc_types_order" See symfony/symfony#28780. Commits ------- 7587534 [standards] Document "phpdoc_types_order"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @jvasseur in #28675 (comment), we can use the
phpdoc_types_orderrule from PHP-CS-Fixer to ensure thatnullis always on the last position in phpDocs as proposed in #28675.