Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax #28636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2018

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Sep 29, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28627
License MIT
Doc PR

The X-Accel-Mapping header does not use the standard HTTP key=value syntax, so using HeaderUtils::combine() breaks paths with upper-case letters.

There is no good reason to use HeaderUtils::combine() in this case, so simply skip it.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(could use "list" for consistency with the code base)

@nicolas-grekas nicolas-grekas changed the title X-Accel-Mapping does not use HTTP key=value syntax [HttpFOundation] X-Accel-Mapping does not use HTTP key=value syntax Sep 29, 2018
@nicolas-grekas nicolas-grekas changed the title [HttpFOundation] X-Accel-Mapping does not use HTTP key=value syntax [HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax Sep 29, 2018
@fabpot
Copy link
Member

fabpot commented Sep 30, 2018

Thank you @c960657.

@fabpot fabpot merged commit 09343c2 into symfony:4.1 Sep 30, 2018
fabpot added a commit that referenced this pull request Sep 30, 2018
…ue syntax (c960657)

This PR was squashed before being merged into the 4.1 branch (closes #28636).

Discussion
----------

[HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | #28627
| License       | MIT
| Doc PR        |

The `X-Accel-Mapping` header does not use the standard HTTP key=value syntax, so using `HeaderUtils::combine()` breaks paths with upper-case letters.

There is no good reason to use `HeaderUtils::combine()` in this case, so simply skip it.

Commits
-------

09343c2 [HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax
@fabpot fabpot mentioned this pull request Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.