[HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax #28636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 29, 2018
fabpot
approved these changes
Sep 30, 2018
938e0e8 to
09343c2
Compare
|
Thank you @c960657. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2018
…ue syntax (c960657) This PR was squashed before being merged into the 4.1 branch (closes #28636). Discussion ---------- [HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | #28627 | License | MIT | Doc PR | The `X-Accel-Mapping` header does not use the standard HTTP key=value syntax, so using `HeaderUtils::combine()` breaks paths with upper-case letters. There is no good reason to use `HeaderUtils::combine()` in this case, so simply skip it. Commits ------- 09343c2 [HttpFoundation] X-Accel-Mapping does not use HTTP key=value syntax
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
X-Accel-Mappingheader does not use the standard HTTP key=value syntax, so usingHeaderUtils::combine()breaks paths with upper-case letters.There is no good reason to use
HeaderUtils::combine()in this case, so simply skip it.