[DomCrawler] Change ->text() , ->html() and ->attr() methods to retur…

…n null if node list is empty
symfony · rajaamerkhan · Sep 26, 2018 · Sep 26, 2018 · Sep 26, 2018 · b0e20bcc2b7b63b6c654d0253f6f7004280c973e
commit b0e20bcc2b7b63b6c654d0253f6f7004280c973e
diff --git a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
@@ -350,7 +350,7 @@ public function testReduce()
    public function testAttr()
    {
        $this->assertEquals('first', $this->createTestCrawler()->filterXPath('//li')->attr('class'), '->attr() returns the attribute of the first element of the node list');
-        $this->assertEquals(null, $this->createTestCrawler()->filterXPath('//ol')->attr('class'), '->attr() returns null if the node list is empty');
+        $this->assertNull($this->createTestCrawler()->filterXPath('//ol')->attr('class'), '->attr() returns null if the node list is empty');
    }

    public function testMissingAttrValueIsNull()
@@ -379,14 +379,14 @@ public function testNodeName()
    public function testText()
    {
        $this->assertEquals('One', $this->createTestCrawler()->filterXPath('//li')->text(), '->text() returns the node value of the first element of the node list');
-        $this->assertEquals(null, $this->createTestCrawler()->filterXPath('//ol')->text(), '->text() returns null if the node list is empty');
+        $this->assertNull($this->createTestCrawler()->filterXPath('//ol')->text(), '->text() returns null if the node list is empty');
    }

    public function testHtml()
    {
        $this->assertEquals('<img alt="Bar">', $this->createTestCrawler()->filterXPath('//a[5]')->html());
        $this->assertEquals('<input type="text" value="TextValue" name="TextName"><input type="submit" value="FooValue" name="FooName" id="FooId"><input type="button" value="BarValue" name="BarName" id="BarId"><button value="ButtonValue" name="ButtonName" id="ButtonId"></button>', trim(preg_replace('~>\s+<~', '><', $this->createTestCrawler()->filterXPath('//form[@id="FooFormId"]')->html())));
-        $this->assertEquals(null, $this->createTestCrawler()->filterXPath('//ol')->html(), '->html() returns null if the node list is empty');
+        $this->assertNull($this->createTestCrawler()->filterXPath('//ol')->html(), '->html() returns null if the node list is empty');
    }

    public function testExtract()