Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Controller][ServiceValueResolver] Making method access case insensitive #28404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

nicoweb
Copy link
Contributor

@nicoweb nicoweb commented Sep 8, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28254
License MIT
Doc PR -

Fix #28254 by making the method access insensitive in ServiceValueResolver.

@ostrolucky
Copy link
Contributor

Does this handle older AppBundle:Blog:list notation (notice no :: in there)?

@nicolas-grekas
Copy link
Member

@ostrolucky the attached patch searches for only one : so it will work equally well with one or two :.
Also, I don't think the old notation ever hits the ServiceValueResolver: it is resolved before.

@nicolas-grekas
Copy link
Member

Thank you @nicoweb.

@nicolas-grekas nicolas-grekas merged commit cc6f827 into symfony:3.4 Sep 9, 2018
nicolas-grekas added a commit that referenced this pull request Sep 9, 2018
…se insensitive (nicoweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[Controller][ServiceValueResolver] Making method access case insensitive

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28254
| License       | MIT
| Doc PR        | -

Fix #28254 by making the method access insensitive in `ServiceValueResolver`.

Commits
-------

cc6f827 [Controller][ServiceValueResolver] Making method access case insensitive
@nicoweb nicoweb deleted the fix_28254 branch September 9, 2018 09:49
This was referenced Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.