Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DI] Fix dumping some complex service graphs #28366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Sep 4, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28296 (and its duplicates #28355 & #28362 + possibly #28304)
License MIT
Doc PR -

@skalpa
Copy link
Contributor

skalpa commented Sep 4, 2018

It fixed it on my side. Thank you 👍

@FabienSalles
Copy link
Contributor

It fixed it on my side too.

nicolas-grekas added a commit that referenced this pull request Sep 5, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping some complex service graphs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28296 (and its duplicates #28355 & #28362 ~+ possibly #28304~)
| License       | MIT
| Doc PR        | -

Commits
-------

769fd4b [DI] Fix dumping some complex service graphs
@nicolas-grekas nicolas-grekas merged commit 769fd4b into symfony:3.4 Sep 5, 2018
@fabpot
Copy link
Member

fabpot commented Sep 5, 2018

Thank you @nicolas-grekas.

@nicolas-grekas nicolas-grekas deleted the di-fix branch September 5, 2018 07:28
@XWB
Copy link
Contributor

XWB commented Sep 13, 2018

I'm now getting other errors:

(1/1) ErrorExceptionNotice: Undefined variable: f
--
in srcDevDebugProjectContainer.php line 1786
(2/2) Twig_Error_Syntax
Unknown "abbr_class" filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.