Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

add missing translation for uuid validator #27992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

add missing translation for uuid validator #27992

merged 1 commit into from
Jul 19, 2018

Conversation

garak
Copy link
Contributor

@garak garak commented Jul 19, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets related to #27984
License MIT
Doc PR -

@ro0NL
Copy link
Contributor

ro0NL commented Jul 19, 2018 •
edited
Loading

for nl it's

Deze waarde is geen geldige UUID waarde.

Side note:
The form could also be Deze waarde is geen geldig UUID., but i chose to be consistent with the message for ISSN values :)

@apfelbox
Copy link
Contributor

apfelbox commented Jul 19, 2018 •
edited
Loading

for de:

Dies ist keine gültige UUID.

Side note:
Actually in German it is pretty mixed whether the validator uses something like this value ("dieser Wert") and this ("dies") in the translations.
On the other hand, the original texts are inconsistent here as well:

  • This value should be a valid number.
  • This is not a valid IP address.
  • This is not a valid International Bank Account Number (IBAN).
  • This value is not a valid ISBN-10.
  • ...

So, I would just use the my text above for German.

@Cydonia7
Copy link
Contributor

For fr:
Ceci n'est pas un UUID valide.

@javiereguiluz
Copy link
Member

For es:

Este valor no es un UUID válido.

For eu:

Balio hau ez da onartutako UUID bat.

For ca:

Aquest valor no és un UUID vàlid.

@1ed
Copy link
Contributor

1ed commented Jul 19, 2018

en: #27993
hu: #27994

@fabpot
Copy link
Member

fabpot commented Jul 19, 2018

Thank you @garak.

@fabpot fabpot merged commit 7cf840c into symfony:2.8 Jul 19, 2018
fabpot added a commit that referenced this pull request Jul 19, 2018
@fabpot
minor #27992 add missing translation for uuid validator (garak)
08a49bc 
This PR was merged into the 2.8 branch.

Discussion
----------

add missing translation for uuid validator

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | related to #27984
| License       | MIT
| Doc PR        | -

Commits
-------

7cf840c add missing translation for uuid validator
@fabpot
Copy link
Member

fabpot commented Jul 19, 2018

Anyone willing to do a PR with the translations given in the comments here?

@garak garak deleted the 2.8 branch July 19, 2018 11:32
@apfelbox apfelbox mentioned this pull request Jul 19, 2018
Merged
@apfelbox
Copy link
Contributor

@fabpot PR in #27999

fabpot added a commit that referenced this pull request Jul 19, 2018
@fabpot
minor #27999 [Validator] Add several missing translations of the UUID…
9bfa971 
… validation message. (apfelbox)

This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] Add several missing translations of the UUID validation message.

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | (Comments in #27992)   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | —

All the remaining translations from #27992

Commits
-------

ee780f3 Add several missing translations of the UUID validation message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@garak @ro0NL @apfelbox @Cydonia7 @javiereguiluz @1ed @fabpot @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.