[Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid #27813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failure unrelated, will be fixed by: #27809 |
stof
approved these changes
Jul 3, 2018
chalasr
approved these changes
Jul 3, 2018
fabpot
approved these changes
Jul 3, 2018
|
Thank you @stloyd. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2018
…ged subscriber is invalid (stloyd) This PR was merged into the 2.8 branch. Discussion ---------- [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27811 | License | MIT This change prevents error when invalid subscriber is being used. Expected result: ``` The Doctrine connection "root" referenced in service "stof_doctrine_extensions.listener.sluggable" does not exist. Available connections names: default ``` Actual error: ``` Notice: Array to string conversion ``` Commits ------- cf1bc66 [Doctrine Bridge] Fixed usage of wrong variable when tagged subscriber is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents error when invalid subscriber is being used.
Expected result:
Actual error: