[Cache] provider does not respect option maxIdLength with versioning enabled #27752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 27, 2018
| @@ -255,7 +255,8 @@ private function getId($key) | ||
| return $this->namespace.$this->namespaceVersion.$key; | ||
| } | ||
| if (\strlen($id = $this->namespace.$this->namespaceVersion.$key) > $this->maxIdLength) { | ||
| $id = $this->namespace.$this->namespaceVersion.substr_replace(base64_encode(hash('sha256', $key, true)), ':', -22); | ||
| $adjustedKey = substr_replace(base64_encode(hash('sha256', $key, true)), ':', -(strlen($this->namespaceVersion) + 22)); |
There was a problem hiding this comment.
No need for the line split, we're ok with longer lines. Could you add a \ just before strlen also please?
|
@nicolas-grekas I can add tests for AbstractAdapter but I can do it in a day. Is it ok? |
|
Sure, thank you! |
|
Thank you @kshtompel. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 1, 2018
…versioning enabled (Constantine Shtompel) This PR was squashed before being merged into the 3.4 branch (closes #27752). Discussion ---------- [Cache] provider does not respect option maxIdLength with versioning enabled | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27746 | License | MIT | Doc PR | Component symfony/cache generates cache item ID longer then maxIdLength when versioning is enabled Commits ------- ba8b63b [Cache] provider does not respect option maxIdLength with versioning enabled
|
And congrats for your first commit in Symfony :) |
This was referenced Jul 23, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component symfony/cache generates cache item ID longer then maxIdLength when versioning is enabled