symfony · nicolas-grekas · Jun 28, 2018 · Jun 27, 2018 · Jun 25, 2018
diff --git a/...undle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/SessionController.php b/...undle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/SessionController.php
@@ -43,6 +43,14 @@ public function welcomeAction(Request $request, $name = null)
        return new Response(sprintf('Welcome back %s, nice to meet you.', $name));
    }

+    public function cacheableAction()
+    {
+        $response = new Response('all good');
+        $response->setSharedMaxAge(100);
+
+        return $response;
+    }
+
    public function logoutAction(Request $request)
    {
        $request->getSession()->invalidate();

diff --git a/...ny/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Resources/config/routing.yml b/...ny/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Resources/config/routing.yml
@@ -2,6 +2,10 @@ session_welcome:
    path:     /session
    defaults: { _controller: TestBundle:Session:welcome }

+session_cacheable:
+    path:     /cacheable
+    defaults: { _controller: Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\Controller\SessionController::cacheableAction }
+
 session_welcome_name:
    path:     /session/{name}
    defaults: { _controller: TestBundle:Session:welcome }

diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SessionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/SessionTest.php
@@ -126,6 +126,22 @@ public function testTwoClients($config, $insulate)
        $this->assertContains('Welcome back client2, nice to meet you.', $crawler2->text());
    }

+    /**
+     * @dataProvider getConfigs
+     */
+    public function testCorrectCacheControlHeadersForCacheableAction($config, $insulate)
+    {
+        $client = $this->createClient(array('test_case' => 'Session', 'root_config' => $config));
+        if ($insulate) {
+            $client->insulate();
+        }
+
+        $client->request('GET', '/cacheable');
+
+        $response = $client->getResponse();
+        $this->assertSame('public, s-maxage=100', $response->headers->get('cache-control'));
+    }
+
    public function getConfigs()
    {
        return array(

diff --git a/src/Symfony/Component/HttpFoundation/Session/Session.php b/src/Symfony/Component/HttpFoundation/Session/Session.php
@@ -54,8 +54,6 @@ public function __construct(SessionStorageInterface $storage = null, AttributeBa
     */
    public function start()
    {
-        ++$this->usageIndex;
-
        return $this->storage->start();
    }

@@ -160,7 +158,9 @@ public function getUsageIndex()
     */
    public function isEmpty()
    {
-        ++$this->usageIndex;
+        if ($this->isStarted()) {
+            ++$this->usageIndex;
+        }
        foreach ($this->data as &$data) {
            if (!empty($data)) {
                return false;
@@ -185,8 +185,6 @@ public function invalidate($lifetime = null)
     */
    public function migrate($destroy = false, $lifetime = null)
    {
-        ++$this->usageIndex;
-
        return $this->storage->regenerate($destroy, $lifetime);
    }

@@ -195,8 +193,6 @@ public function migrate($destroy = false, $lifetime = null)
     */
    public function save()
    {
-        ++$this->usageIndex;
-
        $this->storage->save();
    }


diff --git a/src/Symfony/Component/HttpFoundation/Session/SessionBagProxy.php b/src/Symfony/Component/HttpFoundation/Session/SessionBagProxy.php
@@ -44,6 +44,9 @@ public function getBag()
     */
    public function isEmpty()
    {
+        if (!isset($this->data[$this->bag->getStorageKey()])) {
+            return true;
+        }
        ++$this->usageIndex;

        return empty($this->data[$this->bag->getStorageKey()]);
@@ -81,8 +84,6 @@ public function getStorageKey()
     */
    public function clear()
    {
-        ++$this->usageIndex;
-
        return $this->bag->clear();
    }
 }