[DI] Avoid leaking unused env placeholders #27681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm tests are failing. Status: needs work |
|
Tests added. Status: needs review |
nicolas-grekas
approved these changes
Jun 22, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 23, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [DI] Avoid leaking unused env placeholders | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27486 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This PR avoids leaking out unused env placeholders, those are not resolved in `resolveEnvPlaceholders()` and such. As a result they are dumped as-is. cc @nicolas-grekas Commits ------- 41f8494 [DI] Avoid leaking unused env placeholders
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids leaking out unused env placeholders, those are not resolved in
resolveEnvPlaceholders()and such. As a result they are dumped as-is.cc @nicolas-grekas