[Messenger] Fixed MessengerPass::guessHandledClasses return type #27633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
suggested changes
Jun 19, 2018
| @@ -40,6 +40,7 @@ | ||
| use Symfony\Component\Messenger\Transport\AmqpExt\AmqpReceiver; | ||
| use Symfony\Component\Messenger\Transport\AmqpExt\AmqpSender; | ||
| use Symfony\Component\Messenger\Transport\ReceiverInterface; | ||
| use Symfony\Component\Serializer\Tests\Fixtures\Dummy; |
|
|
||
| (new MessengerPass())->process($container); | ||
|
|
||
| $this->assertTrue(true); |
There was a problem hiding this comment.
Can you use a better assertion? Typically, you want to assert that the DummyMessage and SecondMessage messages have a registered handler. Look at the testGetClassesFromTheHandlerSubscriberInterface test for an inspiration.
There was a problem hiding this comment.
Take a look to what I wrote 😄
|
Thank you @sroze for your review! I'll fix it as soon as possible 😄 |
|
Also, could you rebase your pull-request to the branch 4.1 as it is a bug? Thank you! |
sroze
approved these changes
Jun 19, 2018
ogizanagi
approved these changes
Jun 19, 2018
|
Thank you @massimilianobraglia. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2018
…n type (massimilianobraglia) This PR was squashed before being merged into the 4.2-dev branch (closes #27633). Discussion ---------- [Messenger] Fixed MessengerPass::guessHandledClasses return type | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Good evening! Thanks for this amazing project. I've searched over issues and PRs and I didn't find anything about this bug I found. Excuse me if this is a duplicate. If you create an implementation of `MessageSubscriberInterface` and yield results from `getHandledMessages` method, a TypeError (like the following) will be raised: ```TypeError: Return value of Symfony\Component\Messenger\DependencyInjection\MessengerPass::guessHandledClasses() must be of the type array, object returned``` `MessengerPass::guessHandledClasses` return type declared is `array`, when `MessageSubscriberInterface::guessHandledClasses()`'s return type is `iterable`. In this PR I have fixed the return type and wrote a simple test for it. I am looking forward your review. Thank you. Massimiliano Commits ------- 0b1c825 [Messenger] Fixed MessengerPass::guessHandledClasses return type
|
Thanks to you, @nicolas-grekas and @sroze |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 20, 2018
…n type (massimilianobraglia) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fixed MessengerPass::guessHandledClasses return type | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #27633 | License | MIT | Doc PR | ø #27633 should have been merged to 4.1. Commits ------- d6b6e96 [Messenger] Fixed MessengerPass::guessHandledClasses return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening! Thanks for this amazing project.
I've searched over issues and PRs and I didn't find anything about this bug I found. Excuse me if this is a duplicate.
If you create an implementation of
MessageSubscriberInterfaceand yield results fromgetHandledMessagesmethod, a TypeError (like the following) will be raised:TypeError: Return value of Symfony\Component\Messenger\DependencyInjection\MessengerPass::guessHandledClasses() must be of the type array, object returnedMessengerPass::guessHandledClassesreturn type declared isarray, whenMessageSubscriberInterface::guessHandledClasses()'s return type isiterable.In this PR I have fixed the return type and wrote a simple test for it.
I am looking forward your review. Thank you.
Massimiliano