[HttpFoundation] Ensure RedisSessionHandler::updateTimestamp returns a boolean #27632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the return type and value now? Any link? |
|
In my case I get |
nicolas-grekas
approved these changes
Jun 18, 2018
|
Hoping to see this in 4.1.1 😁 |
|
Thank you @MatTheCat. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2018
…mp returns a boolean (MatTheCat) This PR was merged into the 4.1 branch. Discussion ---------- [HttpFoundation] Ensure RedisSessionHandler::updateTimestamp returns a boolean | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Since v1.1.0 predis doesn't return the result of `EXPIRE` as a boolean, thus breaking `updateTimestamp` implementation. Maybe it's worth mentioning error messages were useless here: - Symfony: `User Warning: session_write_close(): Failed to write session data with Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler handler` - PHP: `session_write_close(): Session callback expects true/false return value` Commits ------- 079b944 Ensure updateTimestamp returns a boolean
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.1.0 predis doesn't return the result of
EXPIREas a boolean, thus breakingupdateTimestampimplementation.Maybe it's worth mentioning error messages were useless here:
User Warning: session_write_close(): Failed to write session data with Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler handlersession_write_close(): Session callback expects true/false return value