[Framework][Workflow] Added support for interfaces #27596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 14, 2018
lyrixx
approved these changes
Jun 15, 2018
| @@ -329,7 +329,7 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode) | ||
| ->prototype('scalar') | ||
| ->cannotBeEmpty() | ||
| ->validate() | ||
| ->ifTrue(function ($v) { return !class_exists($v); }) | ||
| ->ifTrue(function ($v) { return !class_exists($v) && !interface_exists($v); }) | ||
| ->thenInvalid('The supported class %s does not exist.') |
There was a problem hiding this comment.
The supported class or interface %s does not exist.
There was a problem hiding this comment.
@lyrixx , thanx, fixed
fabpot
approved these changes
Jun 15, 2018
|
Thank you @vudaltsov. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2018
…sov) This PR was squashed before being merged into the 3.4 branch (closes #27596). Discussion ---------- [Framework][Workflow] Added support for interfaces | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I consider this to be a bugfix in config, because `ClassInstanceSupportStrategy` (`InstanceOfSupportStrategy`) actually works with interfaces. Therefore propose to 3.4. Commits ------- 6104c28 [Framework][Workflow] Added support for interfaces
This was referenced Jun 25, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider this to be a bugfix in config, because
ClassInstanceSupportStrategy(InstanceOfSupportStrategy) actually works with interfaces. Therefore propose to 3.4.