using func_get_args() for BC

symfony · weaverryan · Jun 11, 2018 · Jun 12, 2018 · Jun 12, 2018 · Jun 12, 2018
commit ebe9d3b1c76ab931995011d8727d4f016b395ee5
diff --git a/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php b/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php
@@ -52,8 +52,10 @@ public function __construct(TokenStorageInterface $tokenStorage, EventDispatcher
    /**
     * Authenticates the given token in the system.
     */
-    public function authenticateWithToken(TokenInterface $token, Request $request, $providerKey = null)
+    public function authenticateWithToken(TokenInterface $token, Request $request)
    {
+        $providerKey = func_num_args() > 2 ? func_get_arg(2) : null;
+
        $this->migrateSession($request, $token, $providerKey);
        $this->tokenStorage->setToken($token);
-Original file line number
+Diff line change
@@ -52,8 +52,10 @@ public function __construct(TokenStorageInterface $tokenStorage, EventDispatcher
         /**
          * Authenticates the given token in the system.
          */
-        public function authenticateWithToken(TokenInterface $token, Request $request, $providerKey = null)
+        public function authenticateWithToken(TokenInterface $token, Request $request)
         {
+            $providerKey = func_num_args() > 2 ? func_get_arg(2) : null;
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            nicolas-grekas
  

      

      

      


        Jun 12, 2018


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      \func_num_args()

The new argument should be added on the signature between /**/, and on the docblock.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
             $this->migrateSession($request, $token, $providerKey);
             $this->tokenStorage->setToken($token);
-          Expand Down