Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Validator] add domain test for windows check dns #27559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Validator] add domain test for windows check dns #27559

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a42c3e
add point on host for windows check dns
oliviervangest Jun 8, 2018
2a5abc4
change example.com to another-example.com
Jun 9, 2018
658d652
change example.com to exemple.fr
Jun 9, 2018
4cbb2fe
Revert "change example.com to exemple.fr"
oliviervangest Jun 11, 2018
9cec87b
Revert "change example.com to another-example.com"
oliviervangest Jun 11, 2018
e4e75aa
add test valid domain
oliviervangest Jun 12, 2018
69076df
coding standards
oliviervangest Jun 12, 2018
5828623
Merge remote-tracking branch 'upstream/2.8' into ova_add_point_email_…
Jun 13, 2018
b270140
add deprecated on checkMX and checkHost on Email Validator
Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "change example.com to exemple.fr" 
This reverts commit 658d652.
  • Loading branch information
@oliviervangest
oliviervangest committed Jun 11, 2018
commit 4cbb2fe85e83fc4783dc3eb11a19bc61e2b96098
6 changes: 3 additions & 3 deletions 6 src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,20 @@ public function testStrict()
*/
public function testDnsChecks($type, $violation)
{
DnsMock::withMockedHosts(array('exemple.fr' => array(array('type' => $violation ? false : $type))));
DnsMock::withMockedHosts(array('another-example.com' => array(array('type' => $violation ? false : $type))));

$constraint = new Email(array(
'message' => 'myMessage',
'MX' === $type ? 'checkMX' : 'checkHost' => true,
));

$this->validator->validate('foo@exemple.fr', $constraint);
$this->validator->validate('foo@another-example.com', $constraint);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.com.com is valid but test want violation. I continue to investigate


if (!$violation) {
$this->assertNoViolation();
} else {
$this->buildViolation('myMessage')
->setParameter('{{ value }}', '"foo@exemple.fr"')
->setParameter('{{ value }}', '"foo@another-example.com"')
->setCode($violation)
->assertRaised();
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.